Global ilAdvancedMDValues::queryForRecords (int $adv_rec_obj_ref_id, string $adv_rec_obj_type, string $adv_rec_obj_subtype, array $a_obj_id, string $a_subtype, array $a_records, string $a_obj_id_key, string $a_obj_subid_key, array $a_amet_filter=null)

refactor this

Global ilAppointmentFileHandlerFactory::getInstance (array $a_appointment)

get rid of appointment array. Refactor to new appointment object

Global ilassMarkTest::testSetMinimumLevel_High ()

Enhance documentation of class.assMark.php::setMinimumLevel();

Enhance documentation of class.assMark.php::getMinimumLevel();

Global ilAssQuestionPageGUI::insertPageToc (string $a_output)

: support question info and actions in the page XSL directly the current workaround avoids changing the COPage service

Global ilBookingProcessGUI::saveMultipleBookings ()

check if object/user exist in the DB,

Class ilBookingService

: integration into Service structure

Global ilCalendarAppointmentGUI::__construct (ilDate $seed, ilDate $initialDate, int $a_appointment_id=0)

make appointment_id required and remove all GET request

Global ilCalendarAppointmentGUI::askEdit ()

works with milestones???

Global ilCalendarAppointmentTemplate::getEnd ()

check if this is required

Global ilCalendarAuthenticationToken::isIcalExpired ()

enable the cache

Global ilCalendarBlockGUI::__construct ()

check if setLimit is required

Global ilCalendarCopyFilesToTempDirectoryJob::createUniqueTempDirectory ()

refactor to new file system access Create unique temp directory

Global ilCalendarCopyFilesToTempDirectoryJob::getOutputType ()

output should be file type

Global ilCalendarSelectionBlockGUI::$new_rendering

fix in base class

Global ilCalendarViewGUI::getModalForApp ()

fix envent initialisation

Global ilCalendarZipJob::run (array $input, Observer $observer)

use filsystem service

Global ilChatroomUserTest::testGetUsernameFromIlObjUser ()

if required session value is not set, there will be a warning.

Global ilCheckSumOfFileSizesJob::run (array $input, $observer)

use filesystem service

Global ilCollectFilesJob::run (array $input, $observer)

use filsystem service

Global ilConditionHandler::_adjustMovedObjectConditions (int $a_ref_id)

check if something needs to be done here

Global ilConditionHandler::_checkAllConditionsOfTarget (int $a_target_ref_id, int $a_target_id, string $a_target_type="", int $a_usr_id=0)

check member view passthrough

Global ilConsultationHourAppointments::getAppointmentIdsByGroup (int $a_user_id, int $a_ch_group_id, ?ilDateTime $start=null)

check start time

Global ilConsultationHoursGUI::appointmentList ()

add list/filter of consultation hours if user is responsible for more than one other consultation hour series.

Global ilConsultationHoursGUI::initFormSequence (int $a_mode)

get rid of $this->form

Global ilContainer::applyContainerUserFilter (array $objects, ilContainerUserFilter $container_user_filter=null)

this deserves a decentralized general concept (consumers provide object filter types)

move selects to respective components

Global ilCOPageHTMLExport::exportSupportScripts ()

: use ilPageContent js/css functions here (problem: currently they need a page object for init)

Global ilCopyFilesToTempDirectoryJob::createUniqueTempDirectory ()

refactor to new file system access Create unique temp directory

Global ilCopyFilesToTempDirectoryJob::getOutputType ()

output should be file type

Global ilCopyWizardOptions::_allocateCopyId ()

this is not thread safe

Global ilCourseContentGUI::__renderUserItem (array $item, int $level)

Global ilCourseContentGUI::showUserTimings ()

Global ilCourseGroupingAssignmentTableGUI::__formatPath (array $a_path_arr)

use ilPathGUI

Global ilCourseMembershipGUI::getLocalTypeRole (bool $a_translation=false)

refactor delete

Global ilCourseObjectivesGUI::finalTestLimits ()

get rid of this form

Global ilCourseParticipant::__construct (int $a_obj_id, int $a_usr_id)

get rid of these pseudo constants

Global ilCourseParticipants::__construct (int $a_obj_id)

get rid of these pseude constants

Global ilDateTime::increment (string $a_type, int $a_count=1)

refactor return type

Global ilDateTime::setDate ($a_date, int $a_format)

fix ISO_8601 support

Global ilDownloadFilesBackgroundTask::getBucketTitle ()

see comments

Global ilECSCategoryMappingRule::delete ()

move to repository class

Global ilECSCommunityCache::deleteByServerId (int $a_server_id)

move function into CommunityCacheRepository

Global ilECSNodeMappingSettings::read ()

convert to own database table Read settings from db

Class ilErrorHandling

when an error occured and clicking the back button to return to previous page the referer-var in session is deleted -> server error

This class is a candidate for a singleton. initHandlers could only be called once per process anyways, as it checks for static $handlers_registered.

Global ilExerciseManagementCollectFilesJob::collectAssignmentData (int $assignment_id)

Refactoring needed, long method...

Global ilExerciseManagementCollectFilesJob::createUniqueTempDirectory ()

refactor to new file system access Create unique temp directory

Global ilExport::$export_run_dir

currently used in ilLeanringModuleExporter

Global ilExSubmission::getFiles (array $a_file_ids=null, bool $a_only_valid=false, string $a_min_timestamp=null, bool $print_versions=false)

this also returns non-file entries, rename this, see dev.txt.php

Global ilFileDataMail::initAttachmentMaxUploadSize ()

mjansen: Unfortunately we cannot reuse the implementation of ilFileInputGUI

Class ILIAS

review the concept how the object type definition is loaded. We need a concept to edit the definitions via webfrontend in the admin console.

Global ILIAS::getSupplyingExportFiles (string $a_target_dir=".")

modularize!

Global ILIAS::countNotesAndCommentsMultipleObjects (array $obj_ids, int $user_id, bool $no_sub_objs=false)

this is currently used to implement a caching in ilObjListGUI objects.

Global ILIAS::countNotesAndCommentsMultipleObjects (array $obj_ids, bool $no_sub_objs=false)

see comment in db repo class

Global ILIAS::sendNotifications (Note $note, bool $a_changed=false)

: get rid of object type specific code

Global ILIAS::checkUserParameters (int $user_id, string $code="")

: somehow this does not belong here, maybe session manager instead?

Global ILIAS::__construct ( $survey, array $page_data, array $working_data=[], array $errors=[], int $question_title_mode=1)

use data objects

Class ILIAS

this should be moved to a general appraisee/appraisal manager

Class ilLanguage

Das Datefeld wird bei Aenderungen einer Sprache (update, install, deinstall) nicht richtig gesetzt!!! Die Formatfunktionen gehoeren nicht in class.Language. Die sind auch woanders einsetzbar!!! Daher->besser in class.Format

Global ilLDAPServer::toggleDataSource (int $a_ldap_server_id, int $a_auth_mode, int $a_status)

handle multiple ldap servers

Global ilLDAPUserSynchronisation::sync ()

Redirects to account migration if required

Global ilLearningProgressBaseGUI::_getStatusText (int $a_status, ?ilLanguage $a_lng=null)

Move this to a factory.

Global ilLearningProgressBaseGUI::isObjectOffline (int $a_obj_id, string $a_type='')

switch to centralized offline status

Global ilLoggingDBSettings::getLevelByComponent (string $a_component_id)

better performance

Global ilLPListOfProgressGUI::__initUser (int $a_usr_id=0)

check the access checks.

Global ilLPStatusIcons::getImagePathForStatus (int $a_status)

Check whether the default can be replaced by an exception.

Global ilLPStatusPlugin::initPluginObj (int $a_obj_id)

refactor return type

Global ilLuceneAdvancedSearchGUI::fillAdminPanel ()

Couldn't find any of these template variables anywhere.

Global ilLuceneQueryParser::validateQuery ($a_query)

add multi byte query validation.

Global ilLuceneSearchGUI::getDetails ()

rename

Global ilLuceneSearchGUI::getMimeDetails ()

rename

Global ilLuceneSearchGUI::getType ()

rename

Global ilLuceneUserSearchGUI::getDetails ()

rename

Global ilLuceneUserSearchGUI::getType ()

rename Needed for base class search form

Global ilMaterializedPathTree::getRelation (array $a_node_a, array $a_node_b)

add test

Global ilMaterializedPathTree::moveTree (int $a_source_id, int $a_target_id, int $a_position)

check "$this->db->substr(..." call with parameters

Global ilMDEditorGUI::updateQuickEdit_scorm ()

discuss with scorm maintainer how to proceed with this quick edit implementation

Global ilMediaPoolPage::lookupUsages (int $a_id, bool $a_incl_hist=true)

: This should be all in one context -> mob id table

Global ilMembershipCronNotificationsData::$last_run_unix

convert to DateTime

Global ilMembershipGUI::createMailSignature ()

better implementation

Global ilMembershipGUI::printMembers ()

: refactor to own class

Global ilMembershipGUI::readMemberData (array $usr_ids, array $columns)

needs refactoring and should not be located in GUI classes

Global ilMembershipRegistrationCodes::register (int $a_user_id)

Throw exeption if registration is impossible due to other restrictions.

Global ilMembershipRegistrationCodeUtils::useCode (string $a_code, int $a_endnode)

: throw an error if registration fails (max members, availibility...)

Class ilMembershipRegistrationSettings

course, groups)

Global ilNestedSetTree::validateParentRelations ()

add unit test; check failure result fix $row access

Global ilObjCourseGUI::deliverCertificateObject ()

get rid of cert logger

Global ilObjCourseGUI::gatewayObject ()

check deletable

Global ilObjCourseGUI::infoScreenObject ()

Global ilObjCourseGUI::saveMapSettingsObject ()

centralize for course, group, others

Global ilObjCourseGUI::updateInfoObject ()

switch to form

Global ilObject::putInTree (int $parent_ref_id)

role/rbac stuff

Global ilObjectCommonSettingsInterface::legacyForm (ilPropertyFormGUI $form, ilObject $object)

In the future a method form() should also act on new ui form containers.

Global ilObjectPermissionStatusGUI::perminfo ()

use global template

Global ilObjGroupGUI::saveMapSettingsObject ()

use $form->getInput()

Global ilObjLinkResource::create ($a_upload=false)

how to handle this meta data switch

Global ilObjLinkResourceGUI::addLocatorItems ()

is this required?

Global ilObjLinkResourceGUI::initViewMode (?int $new_view_mode=null)

no view mode for workspace?

Global ilObjMediaObject::lookupUsages (int $a_id, bool $a_include_history=true)

: This should be all in one context -> mob id table

Global ilObjQuestionPool::_getSelfAssessmentQuestionTypes ($all_tags=false)

Make it more flexible

Global ilObjRole::_removeObjectId (string $a_role_title)

rename of remove method

Global ilObjRoleTemplateGUI::permSaveObject ()

fix custom transformation

Global ilObjSurvey::_addQuestionblock (string $title="", int $owner=0, bool $show_questiontext=true, bool $show_blocktitle=false, bool $compress_view=false)

move to survey question manager/repo

Global ilObjSurvey::_getConstraints (int $survey_id)

move to constraint manager/repo, use dto

Global ilObjSurvey::_getQuestionblock (int $questionblock_id)

move to survey question manager/repo

Global ilObjSurvey::_hasDatasets (int $survey_id)

move to run manager

Global ilObjSurvey::_instanciateQuestion (int $question_id)

move to factory in pool module

Global ilObjSurvey::addAppraisee (int $a_user_id)

move to appraisal manager

Global ilObjSurvey::addConstraint (int $if_question_id, int $relation, float $value, int $conjunction)

move to constraint manager/repo

Global ilObjSurvey::addConstraintToQuestion (int $to_question_id, int $constraint_id)

move to constraint manager/repo

Global ilObjSurvey::addMaterialTag (ilXmlWriter $a_xml_writer, string $a_material, bool $close_material_tag=true, bool $add_mobs=true, array $attribs=null)

move to export sub-service

Global ilObjSurvey::addQuestionToBlock (int $question_id, int $questionblock_id)

move to survey question manager/repo

Global ilObjSurvey::addRater (int $a_appraisee_id, int $a_user_id, int $a_anonymous_id=0)

move to appraisal manager

Global ilObjSurvey::canExportSurveyCode ()

move to code manager

Global ilObjSurvey::checkConstraint (array $constraint_data, ?array $working_data)

move to run/constraint manager

Global ilObjSurvey::cloneTextblocks (array $mapping)

move to survey question manager

Global ilObjSurvey::closeAppraisee (int $a_user_id)

move to appraisal/run manager/mode

Global ilObjSurvey::createExportDirectory ()

move to export sub-service

Global ilObjSurvey::createImportDirectory ()

move to export sub-service

Global ilObjSurvey::deleteAllUserData (bool $reset_LP=true)

move to run manager/repo

Global ilObjSurvey::deleteAppraisee (int $a_user_id)

move to appraisal manager

Global ilObjSurvey::deleteConstraint (int $constraint_id)

move to constraint manager/repo

Global ilObjSurvey::deleteConstraints (int $question_id)

move to constraint manager/repo

Global ilObjSurvey::deleteRater (int $a_appraisee_id, int $a_user_id, int $a_anonymous_id=0)

move to appraisal manager

Global ilObjSurvey::deleteSurveyCode (string $survey_code)

move to code manager

Global ilObjSurvey::deleteSurveyRecord ()

move to survey manager/repo

Global ilObjSurvey::deleteWorkingData (int $question_id, int $active_id)

move to run(?) manager/repo

Global ilObjSurvey::duplicateQuestionForSurvey (int $question_id, bool $a_force=false)

move to survey question manager/repo

Global ilObjSurvey::findCodeForUser (int $a_user_id)

move to code manager

Global ilObjSurvey::finishSurvey (int $finished_id, int $appr_id=0)

move to run manager

Global ilObjSurvey::getActiveID (int $user_id, string $anonymize_id, int $appr_id)

move to run manager/repo

Global ilObjSurvey::getAllRelations (bool $short_as_key=false)

move to constraint manager/repo

Global ilObjSurvey::getAnonymousIdByCode (string $a_code)

move to code manager

Global ilObjSurvey::getAppraiseesData ()

move to appraisal manager, use dto

Global ilObjSurvey::getAppraiseesToRate (?int $a_user_id, int $a_anonymous_id=null)

move to appraisal manager

Global ilObjSurvey::getConstraints (int $question_id)

move to constraint manager, introduce dto

Global ilObjSurvey::getEvaluationByUser (array $questions, int $active_id)

move to evaluation manager

Global ilObjSurvey::getExportDirectory ()

move to export sub-service

Global ilObjSurvey::getExternalCodeRecipients (bool $a_check_finished=false)

move to code manager

Global ilObjSurvey::getFinishedIdForAppraiseeIdAndRaterId (int $a_appr_id, int $a_rat_id)

move to run manager

Global ilObjSurvey::getFinishedIdsForAppraiseeId (int $a_appr_id, bool $a_exclude_appraisee=false)

move to run manager

Global ilObjSurvey::getImportDirectory ()

move to export sub-service

Global ilObjSurvey::getLastAccess (int $finished_id)

move to run manager

Global ilObjSurvey::getLastActivePage (int $active_id)

move to run manager/repo

Global ilObjSurvey::getNextPage (int $active_page_question_id, int $direction)

move to execution manager

Global ilObjSurvey::getPrecondition (int $constraint_id)

move to constraint manager, introduce dto

Global ilObjSurvey::getQuestionblockQuestionIds (int $questionblock_id)

move to survey question manager/repo

Global ilObjSurvey::getQuestionblockQuestions (int $questionblock_id)

move to survey question manager/repo

Global ilObjSurvey::getQuestionblocksTable (array $arrFilter)

move to survey question manager, use dto

Global ilObjSurvey::getQuestionsTable (array $arrFilter)

move to survey question manager, use dto

Global ilObjSurvey::getRatersData (int $a_appraisee_id)

move to appraisal manager

Global ilObjSurvey::getSurveyCodesForExport (array $a_codes=null, array $a_ids=null)

move to code manager

Global ilObjSurvey::getSurveyCodesTableData (array $ids=null, string $lang=null)

move to code manager

Global ilObjSurvey::getSurveyFinishedIds ()

move to run manager

Global ilObjSurvey::getSurveyPages ()

move to survey question manager/repo, use dto

Global ilObjSurvey::getSurveyParticipants (?array $finished_ids=null, bool $force_non_anonymous=false, bool $include_invites=false)

move to run/participant manager/repo

Global ilObjSurvey::getSurveyQuestions (bool $with_answers=false)

move to survey question manager/repo, use dto

Global ilObjSurvey::getTextblock (int $question_id)

move to survey question manager

Global ilObjSurvey::getUserAccessCode (int $user_id)

move to code manager

Global ilObjSurvey::getUserData (array $ids)

use user service, remove direct access to usr_data table

Global ilObjSurvey::getUserDataFromActiveId (int $active_id, bool $force_non_anonymous=false)

move to run manager/repo

Global ilObjSurvey::getUserSpecificResults (array $finished_ids)

move to evaluation manager

Global ilObjSurvey::getUserSurveyExecutionStatus (string $a_code=null)

move to run manager

Global ilObjSurvey::getVariables (int $question_id)

move to (pool?) question manager/repo

Global ilObjSurvey::getWorkingtimeForParticipant (int $finished_id)

move to run manager?

Global ilObjSurvey::importObject (array $file_info, int $svy_qpl_id)

move to export sub-service

Global ilObjSurvey::importSurveyCode (string $a_anonymize_key, int $a_created, array $a_data)

move to code manager

Global ilObjSurvey::insertQuestion (int $question_id)

move to survey question manager/repo

Global ilObjSurvey::is360SurveyStarted (int $appr_id, int $user_id, string $anonymous_code=null)

move to appraisal manager

Global ilObjSurvey::isAnonymizedParticipant (string $key)

move to participant manager

Global ilObjSurvey::isAppraisee (int $a_user_id)

move to appraisal manager

Global ilObjSurvey::isAppraiseeClosed (int $a_user_id)

move to appraisal manager

Global ilObjSurvey::isComplete ()

move to survey manager

Global ilObjSurvey::isHTML (string $a_text)

move to export sub-service

Global ilObjSurvey::isPluginActive (string $a_pname)

deprecate / abandon

Global ilObjSurvey::isQuestionInAnyBlock (int $a_question_fi)

move to survey question manager/repo

Global ilObjSurvey::isRater (int $a_appraisee_id, int $a_user_id, int $a_anonymous_id=0)

move to appraisal manager

Global ilObjSurvey::isSurveyCodeUnique (string $code)

move to code manager

Global ilObjSurvey::isSurveyCodeUsed (string $code)

move to code manager

Global ilObjSurvey::isSurveyFinishedByCode (string $a_code)

move to run manager

Global ilObjSurvey::isUnusedCode (string $a_code, int $a_user_id)

move to code manager

Global ilObjSurvey::loadWorkingData (int $question_id, int $active_id)

move to run(?) manager/repo

Global ilObjSurvey::locateImportFiles (string $a_dir)

move to export sub-service

Global ilObjSurvey::modifyQuestionblock (int $questionblock_id, string $title, bool $show_questiontext, bool $show_blocktitle, bool $compress_view=false)

move to survey question manager/repo

Global ilObjSurvey::moveQuestions (array $move_questions, int $target_index, int $insert_mode)

move to survey question manager/repo

Global ilObjSurvey::openAllAppraisees ()

move to appraisal manager

Global ilObjSurvey::removeConstraintsConcerningQuestion (int $question_id)

move to constraint manager/repo

Global ilObjSurvey::removeQuestion (int $question_id)

move to survey question manager/repo

Global ilObjSurvey::removeQuestionFromBlock (int $question_id, int $questionblock_id)

move to survey question manager/repo

Global ilObjSurvey::removeQuestions (array $remove_questions, array $remove_questionblocks)

move to survey question manager/repo

Global ilObjSurvey::removeSelectedSurveyResults (array $finished_ids)

move to run manager/repo

Global ilObjSurvey::saveCompletionStatus ()

move to survey manager/repo

Global ilObjSurvey::saveHeading (string $heading, int $insertbefore)

move to survey question manager

Global ilObjSurvey::saveUserAccessCode (int $user_id, string $access_code)

move to code manager

Global ilObjSurvey::sendAppraiseeCloseNotification (int $a_user_id)

move to appraisal manager

Global ilObjSurvey::sendAppraiseeNotification (int $a_user_id)

move to appraisal manager

Global ilObjSurvey::sendCodes (int $not_sent, string $subject, string $message, string $lang)

move to code manager

Global ilObjSurvey::sendRaterNotification (int $a_user_id, int $a_appraisee_id)

move to appraisal manager

Global ilObjSurvey::set360RaterSent (int $a_appraisee_id, int $a_user_id, int $a_anonymous_id, int $a_tstamp=null)

move to appraisal manager

Global ilObjSurvey::setObligatoryStates (array $obligatory_questions)

move to survey question manager/repo

Global ilObjSurvey::setPage (int $finished_id, int $page_id)

move to run manager/repo

Global ilObjSurvey::toXML ()

move to export sub-service

Global ilObjSurvey::unfoldQuestionblocks (array $questionblocks)

move to survey question manager/repo

Global ilObjSurvey::updateCode (int $a_id, string $a_email, string $a_last_name, string $a_first_name, int $a_sent)

move to code manager

Global ilObjSurvey::updateConjunctionForQuestions (array $questions, int $conjunction)

move to constraint manager/repo

Global ilObjSurvey::updateConstraint (int $precondition_id, int $if_question_id, int $relation, float $value, int $conjunction)

move to constraint manager/repo

Global ilObjSurveyGUI::checkRbacOrPositionPermission (string $a_rbac_permission, string $a_position_permission)

move to access manager

Global ilObjSurveyGUI::getUserResultsPlain (int $a_active_id)

move to evaluation sub-service

Global ilObjSurveyGUI::getUserResultsTable (int $a_active_id)

move to evaluation sub-service

Global ilObjSurveyGUI::viewUserResultsObject ()

move to evaluation sub-service

Global ilObjSurveyQuestionPool::_getQuestiontypes ()

move to question manager, use dto

Global ilObjSurveyQuestionPool::_getQuestionTypeTranslations ()

move to question manager, use dto

Global ilObjSurveyQuestionPool::createQuestion (string $question_type, int $question_id=-1)

check this method, it does not seem to create anything

Global ilObjSurveyQuestionPool::getQuestionInfos (array $question_ids)

move to question manager, use dto

Global ilObjSurveyQuestionPool::getQuestionsData (array $arrFilter)

move to question/pool manager

Global ilObjSurveyQuestionPool::getQuestionsInfo (array $question_array)

move to question manager/repo, use dto

Global ilObjSurveyQuestionPool::toXML (?array $questions)

move to export sub-component

Global ilObjUser::_getFeedPass (int $a_user_id)

move to news service

Global ilObjUser::_setFeedPass (int $a_user_id, string $a_password)

move to news service

Global ilObjUser::addToPCClipboard (string $a_content, string $a_time, int $a_nr)

move to COPage service

Global ilObjUser::getPCClipboardContent ()

move to COPage service

Global ilObjUser::refreshLogin ()

set date with now() should be enough

Global ilObjUser::saveAsNew ()

drop fields last_update & create_date.

Global ilPageObject::_handleImportRepositoryLinks (string $a_rep_import_id, string $a_rep_type, int $a_rep_ref_id)

: generalize, internal links usage info

Global ilPageObject::addFileSizes ()

: move to file item class

Global ilPageObject::bbCode2XML (string &$a_content)

: move to paragraph

Global ilPageObject::getFO ()

: deprecated?

Global ilPageObject::getLastUpdateOfIncludedElements ()

: move to content include class

Global ilPageObject::getQuestionIds ()

: move to questions

Global ilPageObject::moveIntLinks (array $a_from_to)

: generalize, internal links usage info

Global ilPageObject::resolveFileItems (array $a_mapping)

: move to file classes?

Global ilPageObject::resolveIIMMediaAliases (array $a_mapping)

: move to iim classes?

Global ilPageObject::resolveMediaAliases (array $a_mapping, bool $a_reuse_existing_by_import=false)

: move to media classes?

Global ilPageObject::resolveQuestionReferences (array $a_mapping)

: move to question classes

Global ilPageObject::resolveResources (array $ref_mapping)

: move this into proper "afterImport" routine that calls all PC components

Global ilPageObject::saveInitialOpenedContent (string $a_type, int $a_id, string $a_target)

begin: generalize

Global ilPageObject::saveInternalLinks (DOMDocument $a_domdoc)

: move to specific classes, internal link use info

Class ilParticipants

move these constants to ilParticipants

Global ilParticipants::_getAllSupportContactsOfUser (int $a_usr_id, string $a_type)

join the two queries or alternatively reuse _getMembershipByType

fix returning fetchAssoc result

Global ilParticipants::autoFillSubscribers ()

check and fix notification

Global ilParticipants::checkLastAdmin (array $a_usr_ids)

fix this and add unit test

Global ilParticipants::getInstanceByObjId (int $a_obj_id)

remove this method in favour of selff::getInstance

Global ilParticipants::readSubscribers ()

fix performance; check if method is in use

Global ilPortfolioExerciseGUI::checkExercise (int $a_user_id, int $a_obj_id, bool $a_add_submit=false, bool $as_array=false)

get rid of mixed return type

Global ilRbacAdmin::applyMovedObjectDidacticTemplates (int $a_ref_id, int $a_old_parent)

implement using event handler

Global ilRbacReview::getAssignableRolesInSubtree (int $ref_id)

move tree to construct.

Global ilRbacReview::getGlobalRoles ()

refactor rolf => DONE

Global ilRbacReview::getObjectOfRole (int $a_role_id)

refactor rolf (due to performance reasons the new version does not check for deleted roles only in object reference)

Global ilRbacReview::getParentRoleIds (int $a_endnode_id, bool $a_templates=false)

move tree to construct. Currently this is not possible due to init sequence

Global ilRbacReview::getRolesOfRoleFolder (int $a_ref_id, bool $a_nonassignable=true)

refactor rolf => RENAME

Global ilRbacReview::isBlockedInUpperContext (int $a_role_id, int $a_ref_id)

move tree to construct.

Global ilRbacReview::isDeleted (int $a_node_id)

delete this method

Global ilRegistrationGUI::addCommandButtons ()

get rid of $this->form

Global ilRegistrationGUI::initForm ()

get rid $this->form

Global ilRegistrationSettingsGUI::$ref_id

make private

Class ilRepositoryExplorerGUI

: isClickable, top node id

Global ilSearchBaseGUI::addPager ($result, string $a_session_key)

check wether result is ilSearchResult or ilLuceneSearchResult and add interface or base class.

Global ilSearchSettings::getEnabledLuceneItemFilterDefinitions ()

This has to be defined in module.xml

Global ilSearchSettings::getLuceneItemFilterDefinitions ()

This has to be defined in module.xml

Global ilSetting::setScormDebug (string $a_key, string $a_val)

this must not be part of a general settings class

Class ilSetupLanguage

The DATE field is not set correctly on changes of a language (update, install, your stable). The format functions do not belong in class.Language. Those are also applicable elsewhere. Therefore, they would be better placed in class.Format

This somehow needs to be reconciled with the base class and most probably be factored into two classes, one for management, one for retrieval.

Global ilStartUpGUI::processCode ()

needs rafactoring

Global ilStartUpGUI::showLoginPage (ilPropertyFormGUI $form=null)

check for forced authentication like ecs, ... Show login page

Global ilSubmissionsZipJob::run (array $input, Observer $observer)

use filesystem service

Class ilSurveyCategory

make a proper dto, get rid of magic functions

Global ilSurveyConstraintsGUI::validateConstraintForEdit (int $a_id)

actually the ID is not checked against the survey

Global ilSurveyEvaluationGUI::getSumScores (?array $a_finished_ids=null)

move to evaluation manager, use dto

Global ilSurveyEvaluationGUI::hasResultsAccess ()

move to access manager

Class ilSurveyMaterial

move to propert dto, get rid of magic functions

Global ilSurveyPageEditGUI::appendNewQuestionToSurvey (int $a_new_id, bool $a_duplicate=true, bool $a_force_duplicate=false)

: move out of GUI class, see also ilObjSurvey->insertQuestion

Global ilSurveyPageEditGUI::movePage ()

this needs to be refactored outside of a GUI class, same with ilSurveyEditorGUI->insertQuestions

Class ilSurveyPhrases

split up in dto and repo class

Global ilSurveyPhrasesGUI::getCategoriesForPhrase (int $phrase_id)

move this to a repo class

Global ilSurveyPhrasesGUI::getPhraseTitle (int $phrase_id)

move this to a repo class

Global ilSurveySkill::determineSkillLevelsForAppraisee (int $a_appraisee_id, bool $a_self_eval=false, int $finished_id=0)

introduce dto

Global ilTestSessionFactory::getSessionByUserId ($userId)

: Björn, we also need to handle the anonymous user here

Global ilTraceProcessor::__invoke (array $record)

fix shifting calls

Global ilTree::checkTree ()

remove exception for "check-method"

Global ilTree::fetchPredecessorNode (int $a_node_id, string $a_type="")

move to tree implementation and throw NotImplementedException for materialized path implementation fix return false

Global ilTree::fetchSuccessorNode (int $a_node_id, string $a_type="")

move to tree implementation and throw NotImplementedException for materialized path implementation fix return false

Global ilTree::fetchTranslationFromObjectDataCache (array $a_obj_ids)

handle dependency

Global ilTree::getChilds (int $a_node_id, string $a_order="", string $a_direction="ASC")

remove dependency to ilObjUser and use $this->lang_code

Global ilTree::getChildsByType (int $a_node_id, string $a_type)

check the perfomance optimization and remove

Global ilTree::getChildSequenceNumber (array $a_node, string $type="")

move to tree implementation and throw NotImplementedException for materialized path implementation

Global ilTree::getLeftValue (int $a_node_id)

move to tree implementation and throw NotImplementedException for materialized path implementation

Global ilTree::getRelation (int $a_node_a, int $a_node_b)

add unit test

Global ilTree::getSubTree (array $a_node, bool $a_with_data=true, array $a_type=[])

remove the in cache exception for lm tree

refactor $a_type to string[]

Global ilTree::initLangCode ()

remove this dependency to user language from tree class

Global ilTree::insertNodeFromTrash (int $a_source_id, int $a_target_id, int $a_tree_id, int $a_pos=self::POS_LAST_NODE, bool $a_reset_deleted_date=false)